Skip to content

feat(passport): ID-3764 Debounce login#2651

Merged
haydenfowler merged 3 commits into
mainfrom
feature/ID-3764-debounce-loginCallback
Jun 6, 2025
Merged

feat(passport): ID-3764 Debounce login#2651
haydenfowler merged 3 commits into
mainfrom
feature/ID-3764-debounce-loginCallback

Conversation

@haydenfowler
Copy link
Copy Markdown
Contributor

Hi👋, please ensure the PR title follows the below standards:

Summary

Calling the login method twice can result in a No matching state found in storage error once the user authenticates. This PR solves this issue by adding debounce logic to the login method.

Detail and impact of the change

Changed

  • Passport: Improved how we handle multiple calls to the login method

@haydenfowler haydenfowler requested a review from a team as a code owner June 6, 2025 03:44
@nx-cloud
Copy link
Copy Markdown

nx-cloud Bot commented Jun 6, 2025

View your CI Pipeline Execution ↗ for commit e5e4fad.

Command Status Duration Result
nx affected -t build,lint,test ✅ Succeeded 2m 59s View ↗
nx run-many -p @imtbl/sdk,@imtbl/checkout-widge... ✅ Succeeded 1m 16s View ↗

☁️ Nx Cloud last updated this comment at 2025-06-06 04:47:39 UTC

@haydenfowler haydenfowler changed the title feat(passport): ID-3764 Debounce loginCallback feat(passport): ID-3764 Debounce login Jun 6, 2025
@haydenfowler haydenfowler added this pull request to the merge queue Jun 6, 2025
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Jun 6, 2025
@haydenfowler haydenfowler added this pull request to the merge queue Jun 6, 2025
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Jun 6, 2025
@haydenfowler haydenfowler added this pull request to the merge queue Jun 6, 2025
Merged via the queue into main with commit 4ae8530 Jun 6, 2025
8 of 9 checks passed
@haydenfowler haydenfowler deleted the feature/ID-3764-debounce-loginCallback branch June 6, 2025 06:16
haydenfowler added a commit that referenced this pull request Sep 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants